Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron detection crashes #29

Closed
zeha opened this issue Apr 30, 2020 · 1 comment
Closed

Electron detection crashes #29

zeha opened this issue Apr 30, 2020 · 1 comment

Comments

@zeha
Copy link

zeha commented Apr 30, 2020

Hi,

when using Jitsi Meet in Ferdi 5.5 - based on Electron - the function _detectElectron in browser-detection/BrowserDetection.js crashes.

navigator.userAgent for this app is:

"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36 Ferdi/5.5.0 (Electron 8.2.3)"

The match attempt done by _detectElectron doesn't work:

userAgent.match(/Electron\/([\d.]+)/)
null

So the [1] array access fails with "Uncaught TypeError: Cannot read property '1' of null".

Jitsi Meet used to work with Ferdi 5.4.3, which I guess was based on an older Electron version.

Thanks,
Chris

@saghul
Copy link
Member

saghul commented Oct 4, 2021

Fixed in #33

@saghul saghul closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants