Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Note that Dict.get is O(n) #1

Closed
alexanderkiel opened this issue Oct 7, 2018 · 3 comments
Closed

Add a Note that Dict.get is O(n) #1

alexanderkiel opened this issue Oct 7, 2018 · 3 comments

Comments

@alexanderkiel
Copy link

You have a nice implementation of a Dict here. But others should know from the start that Dict.get is O(n) so that they can decide whether they can use it.

@jjant
Copy link
Owner

jjant commented Oct 7, 2018

Hey there!

Yes, I think you're right, that should be in the readme. One caveat is that the Dict is not O(n) in the number of elements, but on the number of insertions.

@alexanderkiel
Copy link
Author

Hi! Yes the n is the number of insertions.

@jjant jjant closed this as completed Oct 9, 2018
@jjant
Copy link
Owner

jjant commented Oct 9, 2018

Resolved in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants