Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test datasets: Alternative needed for the Google-Code archive #87

Open
kaustubhmote opened this issue Nov 6, 2018 · 6 comments
Open

Comments

@kaustubhmote
Copy link
Collaborator

I am planning to push a PR (currently my master branch) that writes processed Bruker data back into a format that Topspin can read. This is a fairly big addition and I have included some basic tests to make sure everything works OK. For the new tests to work, I will need to push some additional test datasets (processed topspin data) and some changes to the conversion scripts.

Is there an alternative way of doing this and making them available to the CI, since Google-Code is no longer functional?

@jjhelmus
Copy link
Owner

jjhelmus commented Nov 7, 2018

How big of dataset do the tests require? If For data in the ~10-100 kilobyte range including the file directly in the repository in a data folder should be fine. Larger datasets could be stored in a nmrglue_data repository or as a release artifact which has a 2GB upper limit.

@kaustubhmote
Copy link
Collaborator Author

The additional datasets are themselves relatively small at ~2.5MB (out of which a single 2D is ~2MB). That is still bigger than the nmrglue codebase (!), but I am testing the ability to read and write processed 2D datasets from and into the bruker format which makes smaller sizes a bit difficult. For the current testing requirements, I will make smaller datasets to fit into the data folder tests in fileio and/or change some tests.

However, I think it would be great to have a way to update the test_data_v0.4-dev.zip on google-code archive and run the more extensive tests, atleast locally.

@kaustubhmote
Copy link
Collaborator Author

@jjhelmus and @JLVarjo I am unable to find the testing data for testing PR #120. the test_data_v04-dev.zip file from above is missing jcampdx datasets. Any idea where I can find these?

@JLVarjo
Copy link
Contributor

JLVarjo commented Jun 19, 2020

Hi,
I have it and @jjhelmus should have it, but it seems that this test data archive is not updated. I think this data is not more than few megabytes. Should I upload them to the nmrglue_data repo maybe?

@kaustubhmote
Copy link
Collaborator Author

Maybe you can email it to me for now? We probably should revisit how/where we store these test datasets. It might be best to avoid adding to the repo for now, as most of the datasets will be be larger than than current repo size.

@JLVarjo
Copy link
Contributor

JLVarjo commented Jun 19, 2020

I agree - it would simplify pushing bug fixes if test data could be made instantly available as well. I'll get back to you next monday and e-mail the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants