Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error when using Typescript 3.0.1 and rrule 2.3.2 #244

Closed
thomasvidas opened this issue Aug 8, 2018 · 3 comments
Closed

Compilation error when using Typescript 3.0.1 and rrule 2.3.2 #244

thomasvidas opened this issue Aug 8, 2018 · 3 comments

Comments

@thomasvidas
Copy link

thomasvidas commented Aug 8, 2018

I'm getting this error when running a fairly basic tsconfig.json and tsc

node_modules/rrule/dist/es6/rruleset.d.ts:48:5 - error TS2416: Property 'clone' in type 'RRuleSet' is not assignable to the same property in base type 'RRule'.
  Type '() => RRuleSet' is not assignable to type '() => RRule'.
    Type 'RRuleSet' is not assignable to type 'RRule'.
      Types have separate declarations of a private property '_iter'.

I dug into the types and you can

  • remove private _iter; from dist/rruleset.d.ts
  • replace private _iter; with protected _iter: any; in dist/rrule.d.ts
@thomasvidas thomasvidas changed the title Compilation error when using Typescript 3.0.1 Compilation error when using Typescript 3.0.1 and rrule 2.3.2 Aug 8, 2018
@davidgoli
Copy link
Collaborator

@thomasvidas Addressed by #245

@davidgoli
Copy link
Collaborator

@thomasvidas Deployed in 2.3.3

@thomasvidas
Copy link
Author

Awesome! Thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants