Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo page should import to global/window scope #365

Closed
mdentremont opened this issue Sep 18, 2019 · 2 comments
Closed

Demo page should import to global/window scope #365

mdentremont opened this issue Sep 18, 2019 · 2 comments

Comments

@mdentremont
Copy link

mdentremont commented Sep 18, 2019

Some libraries such as moment, lodash, etc, expose their goodies to the window, such that when on their webpage, I can drop to a JS console and test stuff out myself (ex: I can use _ when on the lodash website).

I would be very useful if we could do the same for this library, I've pushed up a pull-request with the appropriate changes.

@mdentremont
Copy link
Author

mdentremont commented Sep 19, 2019

@thefliik I actually think both would be great -- I tried the sandbox link, and found myself still wanting to drop to the browser debugger just to try some things out quickly (might just be old habits, I tried it out again just now and didn't drop to the debugger yet)

@jorroll
Copy link

jorroll commented Sep 19, 2019

Fair enough 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants