-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitfinex Disconnections-Reconnections #25
Comments
Hi, do you have/can you provide debug logging of when this happens? By design Bitfinex.NET should resubscribe the subscriptions that were running when the disconnect happened. If this doesn't happen (sometimes), then that's a bug. |
Hi Jan.
I'm in a short Vacation.
I'll send logs when I'll be back.
Thanks
edc
Il giorno lun 11 giu 2018 alle ore 09:27 Jan Korf <notifications@github.com>
ha scritto:
… Hi, do you have/can you provide debug logging of when this happens? By
design Bitfinex.NET should resubscribe the subscriptions that were running
when the disconnect happened. If this doesn't happen (sometimes), then
that's a bug.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEmb5pysGtw5sV8KHLWOmKyL0EIG4_KYks5t7hv1gaJpZM4UedNM>
.
|
Hi Jan. In the Activity log You can see a connection/disconnection logged the day 14 at 19:14:25 - 19:14:28 . What I suspect is that connection/disconnection causes the loss of candle subscription. Best regards. edc |
Right Now Another example: I logged:
And Subscriptions (at least candle subscriptions than in my app fires all the events) are gone. |
Hi, I've refactored some of the reconnection handling in the new version (v1.0.13), could you see if this fixes your problems? |
Hi. |
Sorry to hear that, I'll look into it tomorow |
I assume you called the subscribe functions before the Start function in the socket client? I found a bug introduced in version 1.0.13 which caused the subscriptions only to work if called AFTER the start method. This is fixed in 1.0.14, please try that. |
Yes, exactly. Thank You. |
Can you confirm that the subscriptions still work after reconnecting? |
Tested. Thank You. |
Update: |
Great. Do you still have 300s timeouts though? The websocket should reconnect after 15 seconds of not receiving any data, so I would expect that wouldn't be necessary. (server send a heartbeat message every x seconds, which is handled internally in the library) |
Bitfinex.NET connects and reconnects to Bitfinex at least once per day, sometime many times a day.
I get it because I log the events
BitfinexSocketClient.ConnectionLost and BitfinexSocketClient.ConnectionRestored
.Sometimes Bitfinex.NET reconnects but the candle subscription (opened at startup with
BitfinexSocketClient.SubscribeToCandleUpdates
) is not restored.I thought about a timer to detect if data is still arriving and, if not, close-reopen connection from scratch.
Is there a better way to deal with the issue ?
P.S.: my machine is in a datacenter with 99.9 connectivity SLA, so connections/reconnections are probably originated from Bitfinex endpoint and inherent to their service.
The text was updated successfully, but these errors were encountered: