Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --set on cli #266

Closed
cyberox opened this issue Sep 16, 2022 · 3 comments · Fixed by #267
Closed

Add support for --set on cli #266

cyberox opened this issue Sep 16, 2022 · 3 comments · Fixed by #267
Labels
enhancement New feature or request

Comments

@cyberox
Copy link

cyberox commented Sep 16, 2022

Problem Statement

I would like to be able to provide the vals backend path to the helm chart as --set command eg:

helm secrets template bitnami/mysql --name-template mysql --set auth.rootPassword=ref+vault://secret/mysql#/rootPassword

Currently the value is not replaced with the value from vault.

Proposed Solution

support --set option

Environment

  • Helm Version: 3.9.4
  • Helm Secrets Version: 4.0.0
  • OS: Mac
  • Shell: zsh

Additional information

No response

Acceptance Criteria

No response

@cyberox cyberox added the enhancement New feature or request label Sep 16, 2022
@jkroepke
Copy link
Owner

Thats an interesting idea ...

@jkroepke
Copy link
Owner

jkroepke commented Sep 18, 2022

Feature implemented in #267

In additional to

--set auth.rootPassword=ref+vault://secret/mysql#/rootPassword

I have also implement

--set-file auth.rootPassword=secrets+literal://ref+vault://secret/mysql#/rootPassword

for wrapper-less environments like ArgoCD.

Do you have a chance to test this?

helm plugin install https://github.com/jkroepke/helm-secrets --version vals-literal

I would also much appreciate it, if you could look at the documentation, e.g. its enough documented form user perspective.

@cyberox
Copy link
Author

cyberox commented Sep 19, 2022

That was fast!
I tested the --set command and it is working fine, I also added it to our argocd instance, and using the secrets+literal I can finally fetch secrets from vault using helm chart paramters.
Great job, and thank you for the feature!

I configured all of this, using your documentation, and it's very complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants