Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SuiteSparse_METIS_VERSION and provide in generated cmake config #111

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

NeroBurner
Copy link
Collaborator

Extract the METIS version from the compiled with metis.h file and provide the extracted contents via the generated CMake config files as variable SuiteSparse_METIS_VERSION.

Fixes: #109

Extract the METIS version from the compiled with `metis.h` file and
provide the extracted contents via the generated CMake config files as
variable `SuiteSparse_METIS_VERSION`.

Fixes: #109
@NeroBurner NeroBurner added the feature request Request for a new feature or improvement label Dec 12, 2022
@jlblancoc
Copy link
Owner

The cmake implementation looks good 👍

@jlblancoc jlblancoc merged commit 1168096 into master Dec 12, 2022
@NeroBurner NeroBurner deleted the report_SuiteSparse_METIS_VERSION branch December 12, 2022 10:27
@jlblancoc
Copy link
Owner

Make a new released, if that's the only way to get it tested in Ceres.

@NeroBurner
Copy link
Collaborator Author

The METIS_VERSION variable is going to be used in the upcoming ceres-solver 2.2.0 release. In the current ceres-solver 2.1.0 version this variable isn't yet used.

So my first priority is to get ceres-solver 2.1.0 into Hunter, for which the current SuiteSparse-metis-for-windows 1.6.1 release should work perfectly.

Locally I have a branch building the current master of ceres-solver with this new METIS version info, to be prepared for the 2.2.0 release :)
So for now I'd wait with a suitesparse release

@NeroBurner
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide SuiteSparse_METIS_VERSION variable when building with METIS
2 participants