Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CMake config file when OpenBLAS was not used #113

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fixes CMake config file when OpenBLAS was not used #113

merged 1 commit into from
Dec 20, 2022

Conversation

orlandini
Copy link
Contributor

A missing @ would prevent the correct substitution of the WITH_OPENBLAS value at configuration time. Therefore, the if condition would always be met by an external project (since the variable _SuiteSparse_WITH_OPENBLAS would have value @WITH_OPENBLAS).

Copy link
Collaborator

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for fixing this issue!

@NeroBurner NeroBurner merged commit c29d134 into jlblancoc:master Dec 20, 2022
@NeroBurner
Copy link
Collaborator

@jlblancoc should we release a 1.6.2 or because of #111 which adds a feature a 1.7.0? Any opinions?

@jlblancoc
Copy link
Owner

@orlandini good catch 👍 !

@NeroBurner :

should we release a 1.6.2 or because of #111 which adds a feature a 1.7.0? Any opinions?

I don't have a strong opinion in this case, but would slightly favor a new minor version bump (1.7.0). Thanks!

@NeroBurner
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants