Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extraneous num_elements specialization #121

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

jlchan
Copy link
Owner

@jlchan jlchan commented May 9, 2023

@ranocha not sure why #120 is failing, but this seems to achieve the same result without Windows CI failing.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #121 (9645043) into main (fbc55b9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.19%   96.19%   -0.01%     
==========================================
  Files          25       25              
  Lines        2842     2837       -5     
==========================================
- Hits         2734     2729       -5     
  Misses        108      108              
Impacted Files Coverage Δ
src/MeshData.jl 95.13% <100.00%> (+0.51%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlchan jlchan merged commit 2dd29c3 into main May 9, 2023
@jlchan jlchan deleted the jc/remove_num_elements branch May 12, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant