Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extraneous num_elements specialization #121

Merged
merged 3 commits into from
May 9, 2023
Merged

remove extraneous num_elements specialization #121

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdf39f1
remove extraneous num_elements specialization
jlchan May 9, 2023
30a8178
use getfield instead of getproperty
jlchan May 9, 2023
9645043
fix error
jlchan May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/MeshData.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,7 @@ function Base.getproperty(x::MeshData{Dim, <:VertexMappedMesh}, s::Symbol) where
end
end

num_elements(md::MeshData) = size(md.x, 2) # number of columns in the "x" coordinate array
num_elements(md::MeshData{Dim, <:VertexMappedMesh}) where {Dim} = size(md.mesh_type.EToV, 1)
@inline num_elements(md::MeshData) = size(first(getfield(md, :xyz)), 2) # number of columns in the coordinate array

# splat `uniform_mesh` arguments, e.g., enables `MeshData(uniform_mesh(Line(), 1), rd)`
# TODO: wrap `uniform_mesh` in a custom type so we can dispatch more precisely
Expand Down