Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]solemn vigil does not restore its original cost after one's turn ends #458

Closed
tonyyyye opened this issue May 29, 2018 · 2 comments
Closed

Comments

@tonyyyye
Copy link
Contributor

tonyyyye commented May 29, 2018

omit the former steps.


        game.end_turn()
        assert vigil3.cost == 5
E    AssertionError: assert 0 == 5
E     +  where 0 = <Spell ('Solemn Vigil')>.cost
@tonyyyye
Copy link
Contributor Author

tonyyyye commented May 29, 2018

in collectible.py
we have this:

class BRM_001:
	"""Solemn Vigil"""
	play = Draw(CONTROLLER) * 2
	cost_mod = -Attr(GAME, GameTag.NUM_MINIONS_KILLED_THIS_TURN)

@jleclanche was it designed as the script or am I understanding this in a wrong way?

@tonyyyye
Copy link
Contributor Author

tonyyyye commented Jun 4, 2018

Find out the problem.
game.players.minions_killed_this_turn needed restoring when game.end_turn

Think I've solved this by #459

@shinoi2 shinoi2 closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants