Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail build only after all sources are checked. #19

Closed
Tapchicoma opened this issue Aug 15, 2017 · 3 comments
Closed

Fail build only after all sources are checked. #19

Tapchicoma opened this issue Aug 15, 2017 · 3 comments
Assignees
Labels

Comments

@Tapchicoma
Copy link
Collaborator

When plugin runs checks it fails the build on first failed check task(for example, test sources) and doesn't run others checks(for example, main sources).

It becomes more inconvenient in multi-module projects.

Plugin should run all check tasks and fail build after all check tasks run if one or more of them are failed.

@JLLeitschuh
Copy link
Owner

I think this is normal for most plugins.
I think that spotless behaves the same way.

@wolfs
Copy link
Contributor

wolfs commented May 30, 2018

How about using --continue when running the check tasks? This would cause all of the check tasks to run even if some of them failed.

@Tapchicoma
Copy link
Collaborator Author

@wolfs yep, should work. Will update README.md with this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants