Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect new namespace heirarchy #97

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

jardhu
Copy link
Collaborator

@jardhu jardhu commented Nov 16, 2019

In the documentation, specifically testing, many of the included examples assume that the testing classes lie within the dinocpu package. Since these were moved to dinocpu.test, running them would result in no tests being executed since the class wouldn't be found.

This PR aims to correct any bad references to these classes in the documentation. Right now it corrects any dinocpu.test classes, but there may be others that I am not aware of.

This should close #86 once merged.

@@ -6,7 +6,7 @@ If you run the test under the "Grader" config, you can run just the grading scri
This assumes that you are running inside the gradescope docker container.

```
sbt "Grader / testOnly dinocpu.LabXGrader"
sbt "Grader / testOnly dinocpu.test.grader.LabXGrader"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now... we might want to try to find a way to make this easier for students.

@jardhu jardhu merged commit b9c1da8 into jlpteaching:master Nov 16, 2019
@jardhu
Copy link
Collaborator Author

jardhu commented Nov 16, 2019

Perhaps I can do research on how to alias these classes so they show up in the dinocpu package somehow? I have an idea to create some kind of auto-generated wrapper class which takes the same name as the underlying dinocpu.test class and just runs that test. But I don't know if that's even possible to do in Scala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create hierarchy in classes
2 participants