Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pipeline code to dinocpu.pipelined package #94

Closed
jardhu opened this issue Nov 13, 2019 · 4 comments
Closed

Move pipeline code to dinocpu.pipelined package #94

jardhu opened this issue Nov 13, 2019 · 4 comments
Assignees

Comments

@jardhu
Copy link
Collaborator

jardhu commented Nov 13, 2019

This should be simple to tackle - to close #86 and help make the dinocpu namespace cleaner, the pipelined CPU models and stage register should all go into a dinocpu.pipelined package.

@jardhu jardhu self-assigned this Nov 13, 2019
@powerjg powerjg added this to the ECS154B WQ '20 milestone Nov 13, 2019
@jardhu
Copy link
Collaborator Author

jardhu commented Nov 15, 2019

Closed by #95.

@jardhu jardhu closed this as completed Nov 15, 2019
@jardhu
Copy link
Collaborator Author

jardhu commented Nov 16, 2019

@powerjg, Looks like I need to do one more thing to close this issue. Since I moved the tester classes to dinocpu.test, all of the test commands in sbt must now utilize dinocpu.test instead of dinocpu: for example, testOnly dinocpu.test.PipelinedCPUTester -- -z jal. The documentation wasn't updated with this in mind since I forgot this would be an issue.

I'll create a new patch in a bit to update the docs.

@jardhu jardhu reopened this Nov 16, 2019
@powerjg
Copy link
Contributor

powerjg commented Nov 16, 2019 via email

@jardhu
Copy link
Collaborator Author

jardhu commented Nov 16, 2019

Closed by #97. We could perhaps do some looking into a way to automatically alias the classes in dinocpu.test so that they can be run with testOnly dinocpu.XXXXX.

@jardhu jardhu closed this as completed Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants