Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings in test output #98

Merged
merged 4 commits into from
Nov 23, 2019
Merged

Conversation

jardhu
Copy link
Collaborator

@jardhu jardhu commented Nov 19, 2019

This PR addresses #96 by fixing a few bugs regarding the elaboration of the CPU models. Once complete, all warnings about MemoryOperation casting and the StageReg clone type should no longer show up.

This helps to clear up the testing log and allow people to locate any erroneous register values or failed tests.

Copy link
Contributor

@powerjg powerjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerjg
Copy link
Contributor

powerjg commented Nov 22, 2019

Ready to be merged?

@jardhu
Copy link
Collaborator Author

jardhu commented Nov 23, 2019

Not yet. There are some other MemoryOperation casting warnings popping up that I can't seem to pinpoint. The issue happens whenever I use the 0.U.asTypeOf (new MemoryOperation) type code but this doesn't show up anywhere anywhere, at least all the instances that I am aware of.

@jardhu jardhu merged commit ef4caf9 into jlpteaching:master Nov 23, 2019
@jardhu jardhu deleted the warning-spam branch November 23, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants