Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load performance issue with concatenate #9

Closed
BrannonKing opened this issue Nov 11, 2021 · 1 comment
Closed

load performance issue with concatenate #9

BrannonKing opened this issue Nov 11, 2021 · 1 comment

Comments

@BrannonKing
Copy link

See the attached image of the profiler output. You can see that most of the import time is np.concatenate. Can we not figure out the correct dimensions early on, by the time we're adding the column data? If not, we might need to append to lists and then generate the final array at the end. The rest of the time is in the list indexer because you're relying on exceptions. Don't ever rely on an exception. They tend to be two orders of magnitude slower than an if statement.

image

@jmaerte
Copy link
Owner

jmaerte commented Nov 12, 2021

Hi!

This code was not originally meant for large problems and thus the reliances on imperformant instructions.

However I am well aware of the problem and of the fact that this is used for larger problems now. The numpy_free branch has a version that fixes this issue.

Take a look at it and let me know what you think.

Best regards!

@jmaerte jmaerte closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants