New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal `is_valid_date_string()` is wrong #155

Closed

jmbarbone opened this issue Oct 18, 2022 · 0 comments · Fixed by #156

Assignees

Labels

bug 🐛

Milestone

Owner

jmbarbone commented Oct 18, 2022

Something is wrong with the check

x <- c("2020-12-17", NA_character_, "", "2020-12-UN", "2020-12-UN",
       "2019-Unknown-00", "UNK-UNK-UNK", "1991-02-UN", "    ",
       "2020January20")
mark::date_from_partial(x)
#>  [1] NA           NA           NA           "2020-12-01" "2020-12-01"
#>  [6] "2019-01-01" NA           "1991-02-01" NA           "2020-01-20"

mark:::is_valid_date_string("2022-10-17")
#> [1] FALSE

^{Created on 2022-10-17 with reprex v2.0.2}

jmbarbone added the bug 🐛 label

jmbarbone added this to the 0.5.4 milestone

jmbarbone self-assigned this

jmbarbone mentioned this issue

155-valid-date-string #156

Merged

jmbarbone closed this as completed in #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment