fix: diagnostics not updating #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbuhr
requested changes
Mar 4, 2024
jmbuhr
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue mentioned in conversation in #81
No longer will you have to write the file twice to see the most up to date diagnostics! The reason that this was happening before is that we just weren't giving the LS long enough to give up new diagnostics before trying to refresh them. This caused some really really annoying behavior.
This PR makes use of the
DiagnosticChagnedevent (which I didn't know existed until a few hours ago) to update diagnostics in the buffers we're interested in after the LS has updated the diagnostics.I've also fixed a few small bugs in
sync_raftwhich were previously only just using more CPU cycles, they were messing with this change, causing diagnostics to flicker.as I'm writing this, i remembered that I didn't update theI don't need to do that.deactivatemethod. I'll do that quickly before I go to sleep.