New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opts): failing to opt-out features (completion and diagnostics) #83

Merged

jmbuhr merged 1 commit into jmbuhr:main from atusy:opt-out-features

Jan 22, 2024

Contributor

atusy commented Jan 22, 2024

Following lines become true even if the specified values are false.
This PR fixes it.

  completion = completion or true
  diagnostics = diagnostics or true

Now, nil and true are treated as true and false is treated as false


          fix(opts): failing to opt-out features (completion and diagnostics)

8cd2b34

Owner

jmbuhr commented Jan 22, 2024

Good catch, thanks!

jmbuhr merged commit 0eeb4f9 into jmbuhr:main

github-actions bot mentioned this pull request

chore(main): release 1.7.1 #82

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet