Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .bowerrc and updating README with documentation on how to contribute #64

Merged
merged 1 commit into from
May 20, 2014
Merged

Adding .bowerrc and updating README with documentation on how to contribute #64

merged 1 commit into from
May 20, 2014

Conversation

kentcdodds
Copy link
Contributor

The .bowerrc is to tell bower to install stuff directly into bower_components because by default it installs them in app/bower_components and all the tests depend on them being in bower_components. Feel free to ask me to make changes to the steps. But those are the steps I took to make this PR and I thought they were reasonable :-)

@jmdobry jmdobry added this to the 0.9.0 milestone May 20, 2014
@jmdobry
Copy link
Member

jmdobry commented May 20, 2014

This is great. Hadn't gotten around to this stuff yet.

jmdobry added a commit that referenced this pull request May 20, 2014
Adding .bowerrc and updating README with documentation on how to contribute
@jmdobry jmdobry merged commit e83f887 into js-data:master May 20, 2014
@kentcdodds
Copy link
Contributor Author

Yup :-) I want to help where I can. Docs is a good place to start

@jmdobry
Copy link
Member

jmdobry commented May 20, 2014

@kentcdodds Do you have a global .bowerrc configuration file that sends your installs to app/bower_components? Mine install by default to just bower_components. (Or perhaps I have a global configuration that sends them there.)

@kentcdodds
Copy link
Contributor Author

You're right! I do! Don't know why I have that... Haha. But we should probably leave it in just in case I guess :-)

jmdobry added a commit that referenced this pull request May 20, 2014
Other grunt/CI task fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants