Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change String to an Array of Unsigned8 values #36

Closed
jmeaster30 opened this issue Aug 11, 2023 · 3 comments
Closed

Change String to an Array of Unsigned8 values #36

jmeaster30 opened this issue Aug 11, 2023 · 3 comments
Labels
Bytecode Stuff dealing with the hydro bytecode Feature this is something we need to add Hydro Concerns with the Hydro language Lexer change with the lexing Parser change with the parser UHOH this is a bug

Comments

@jmeaster30
Copy link
Owner

Realized there is no need for strings specifically and we can just use Unsigned8s in an Array to get the same effect
@jmeaster30 jmeaster30 added UHOH this is a bug Hydro Concerns with the Hydro language Bytecode Stuff dealing with the hydro bytecode labels Aug 11, 2023
@jmeaster30
Copy link
Owner Author

Will now need some changes to the parser.

We don't currently support string and char variables but it would be nice to allow someone to type out a string and have it represent a u8 array. If it is a single byte then it represents a u8 instead.

@jmeaster30 jmeaster30 added Feature this is something we need to add Lexer change with the lexing Parser change with the parser labels Aug 13, 2023
@jmeaster30
Copy link
Owner Author

Also we currently produce a string when we are pushing an identifier for indexing.

I think we should make an access instruction that has a built in identifier in it instead of relying on the index instruction. Splitting them up will probably make the code a little simpler too.

@jmeaster30
Copy link
Owner Author

This has been complete. We got rid of strings a little bit ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bytecode Stuff dealing with the hydro bytecode Feature this is something we need to add Hydro Concerns with the Hydro language Lexer change with the lexing Parser change with the parser UHOH this is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmeaster30