-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for response headers policy use #41
Conversation
Hi @jmgreg31, hope you're still watching this repo (it lacks any activity from 2021). I tried to add the feature and the CI fails on |
Hey @slonokot thanks for the PR! To be honest, once the supported module was released, I hadn’t spent much time keeping this module up to date with the latest since it is very similar in implementation. https://github.com/terraform-aws-modules/terraform-aws-cloudfront Looks like the acct creds expired where the integration tests were running and will take a closer look into it. |
@jmgreg31 Thank you for looking into it! Yes, I evaluated moving to that module - it would require quite an investment at this point due to different API. |
@slonokot Can you rebase and push. Spent time today working on migrating from Travis to native GitHub Actions and believe this should be resolved now. Apologies in advance for the git history since I had to actively test being the first time looking into actions specifically |
6fdee57
to
f5758a8
Compare
@slonokot tried to review the docs of reusable workflows from forks as I think that's the issue with passing secrets and why the run was failing on your commits. I think changing to the default If you can resolve the |
@slonokot Appreciate the patience, I still am having trouble passing the AWS Creds to the Environment. I'll have to take a closer look at it later, but don't want to hold this up for you any longer. Changes are merged and released |
@jmgreg31 very much appreciated! If every repository owner was that kind 😄 |
Co-authored-by: Jonathan Greg <31892308+jmgreg31@users.noreply.github.com> Co-authored-by: Jon Greg <jmgreg31@gmail.com> Co-authored-by: Sergey Liberman <sergey.liberman@autodesk.com>
Add support for response headers policies use.
In cases when Security headers, CORS or custom headers are need to be added to the response headers one is forced to have to add a proxy or Lambda@edge origin response function to add the headers. This feature removes the requirement.