Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for response headers policy use #41

Merged
merged 7 commits into from
Feb 12, 2023

Conversation

slonokot
Copy link
Contributor

Add support for response headers policies use.
In cases when Security headers, CORS or custom headers are need to be added to the response headers one is forced to have to add a proxy or Lambda@edge origin response function to add the headers. This feature removes the requirement.

@slonokot
Copy link
Contributor Author

Hi @jmgreg31, hope you're still watching this repo (it lacks any activity from 2021). I tried to add the feature and the CI fails on Error: error configuring S3 Backend: no valid credential sources for S3 Backend found. Can I ask you to help me figuring this out?

@jmgreg31
Copy link
Owner

Hey @slonokot thanks for the PR! To be honest, once the supported module was released, I hadn’t spent much time keeping this module up to date with the latest since it is very similar in implementation. https://github.com/terraform-aws-modules/terraform-aws-cloudfront

Looks like the acct creds expired where the integration tests were running and will take a closer look into it.

@slonokot
Copy link
Contributor Author

slonokot commented Feb 5, 2023

@jmgreg31 Thank you for looking into it!

Yes, I evaluated moving to that module - it would require quite an investment at this point due to different API.

@jmgreg31
Copy link
Owner

jmgreg31 commented Feb 6, 2023

@slonokot Can you rebase and push. Spent time today working on migrating from Travis to native GitHub Actions and believe this should be resolved now. Apologies in advance for the git history since I had to actively test being the first time looking into actions specifically

@jmgreg31
Copy link
Owner

jmgreg31 commented Feb 6, 2023

@slonokot tried to review the docs of reusable workflows from forks as I think that's the issue with passing secrets and why the run was failing on your commits. I think changing to the default GITHUB_TOKEN instead of the one I configured for the environment should work (and is why it worked from a PR of local branch instead of a fork). As a sanity check, I created a quick PR with the action updates and the changes you provided. #49

If you can resolve the staging.yml workflow conflict, I am hoping that will resolve the issue.

@jmgreg31 jmgreg31 merged commit 55ae765 into jmgreg31:staging Feb 12, 2023
@jmgreg31
Copy link
Owner

@slonokot Appreciate the patience, I still am having trouble passing the AWS Creds to the Environment. I'll have to take a closer look at it later, but don't want to hold this up for you any longer. Changes are merged and released v4.3.6. Thanks again!

@slonokot
Copy link
Contributor Author

@jmgreg31 very much appreciated! If every repository owner was that kind 😄

jmgreg31 added a commit that referenced this pull request May 27, 2023
Co-authored-by: Jonathan Greg <31892308+jmgreg31@users.noreply.github.com>
Co-authored-by: Jon Greg <jmgreg31@gmail.com>
Co-authored-by: Sergey Liberman <sergey.liberman@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants