Skip to content

Commit

Permalink
feat: mark angular packages as side-effect free (angular#22785)
Browse files Browse the repository at this point in the history
This flag is picked up by webpack v4 and used for more agressive optimizations.

Our code is already side-effect free, because that's what we needed for build-optimizer to work.

PR Close angular#22785
  • Loading branch information
IgorMinar authored and mhevery committed Mar 15, 2018
1 parent 81e9868 commit dc0d42c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,6 @@
},
"ng-update": {
"packageGroup": "NG_UPDATE_PACKAGE_GROUP"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion upgrade/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"typings": "./upgrade.d.ts",
"main": "../bundles/router-upgrade.umd.js",
"module": "../esm5/upgrade.js",
"es2015": "../esm2015/upgrade.js"
"es2015": "../esm2015/upgrade.js",
"sideEffects": false
}

0 comments on commit dc0d42c

Please sign in to comment.