Create Method to get the OIFITS standard of the OIFitsFile

[Hitogoroshi]

FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(FitsConstants.KEYWORD_CONTENT) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1) is used 4 time !

Proposal:
/**
* define the version of the file
*
* @return the version
*/
public OIFitsStandard defineOIFITSVersion() {
return (FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(FitsConstants.KEYWORD_CONTENT) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1);
}

[bourgesl]

It looks strange !

The expression "FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(FitsConstants.KEYWORD_CONTENT) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1)" is CONSTANT !

C1.equals(C2) ? V1 : V2 => V1 or V2 !

Please verify the use cases.

You would need instead:
public OIFitsStandard getOIFitsStandard(String content) {
return (FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(content) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1);
}

[Hitogoroshi]

Right.
Last problem is where to place the method.
We have a use like this when oifitsfile does not exist yet.

[bourgesl]

Make a static public method in the appropriate class ...

"We have a use like this when oifitsfile does not exist yet."
Alright, what is your proposal ?

[Hitogoroshi]

In OIFITSFILE:
use : (FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(FitsConstants.KEYWORD_CONTENT) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1) to define version. (2 times)

In OIFITSLOADER:
use: (FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(content) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1) to define version of OIFITS
with content = header.getTrimmedStringValue(FitsConstants.KEYWORD_CONTENT) ( 2 times)

[bourgesl]

Check & verify the OIFITSFILE as it looks buggy !

[Hitogoroshi]

We have in OiFitsFile a comparison with constants (used two times):

(FitsConstants.KEYWORD_CONTENT_OIFITS2.equals(FitsConstants.KEYWORD_CONTENT) ? OIFitsStandard.VERSION_2 : OIFitsStandard.VERSION_1)

We need to check its effect

Proposal:
Can delete the method : checker.inspectRuleFailed() (Special case which catch the failures using directly the applyTo and version information)

To

checker.ruleFailed(Rule.OIFITS_OI_TARGET_EXIST);
which now can process rules begin with OIFITS (And add "FILE" in the applyTo for this rules).

[Hitogoroshi]

Question related to the review of the method:
inspectRuleFailed(final Rule rule, final String applyTo, final OIFitsStandard standard)

Maybe new issue

[bourgesl]

I still do not understand anything...

[gmella]

Yes, what is the question related to the review of the method ?

[Hitogoroshi]

Create Method to define version of the File in OIFitsFile done:
getOIFitsStandard(content)

[bourgesl]

still waiting for patch

[bourgesl]

Fix pushed