Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint for booking an amenity #113

Open
jmprathab opened this issue Aug 8, 2020 · 19 comments
Open

Endpoint for booking an amenity #113

jmprathab opened this issue Aug 8, 2020 · 19 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Contribute to Hacktoberfest 2020! up-for-grabs up-for-grabs

Comments

@jmprathab
Copy link
Owner

jmprathab commented Aug 8, 2020

⚠️ Is your feature request related to a problem? Please describe

  • Endpoint for booking an amenity

💡 Describe the solution you'd like

  • POST /amenities/{amenityId}/bookings
  • Update postman collection

Task Relationship

Subtask of: #94

@jmprathab jmprathab added enhancement New feature or request good first issue Good for newcomers up-for-grabs up-for-grabs labels Aug 8, 2020
@zhupanovdm
Copy link

@jmprathab Hello, I'm new in open source, can I take this task?

@jmprathab
Copy link
Owner Author

@zhupanovdm Sure. Request you to comment on your approach before implementing.

@mslowiak mslowiak added the hacktoberfest Contribute to Hacktoberfest 2020! label Oct 2, 2020
@mslowiak
Copy link
Collaborator

mslowiak commented Oct 2, 2020

@zhupanovdm
Any update from you?

@zhupanovdm
Copy link

Hi. Sorry for silence. There was a lack of spare time. But now I'm in.

@mslowiak
Copy link
Collaborator

@zhupanovdm How it is going?

@mslowiak
Copy link
Collaborator

It has been 9 days since last update, task is still up for grabs :)

@tomsajuk
Copy link
Contributor

Shall I take this up?

@tomsajuk
Copy link
Contributor

Hi @jmprathab had some queries regarding the issue. Posting it below:

  1. Should a user be able to book an amenity for another user? (neighbours maybe)
  2. Any restrictions on the number of bookings and people at a particular time-slot? (There would be rush during weekends)
  3. Can assume that the user can only book an amenity available in his community? (Would be throwing error if outside the community, so what error should I throw?)
  4. Whats the purpose of the 'price' attribute in the Amenity domain? Should the user be paying at the time of booking or its a membership fee?

If you could answer these queries would help a lot in the implementation. :) If you add your thinking that would also be good.

@jmprathab
Copy link
Owner Author

Hi @jmprathab had some queries regarding the issue. Posting it below:

  1. Should a user be able to book an amenity for another user? (neighbours maybe)
  2. Any restrictions on the number of bookings and people at a particular time-slot? (There would be rush during weekends)
  3. Can assume that the user can only book an amenity available in his community? (Would be throwing error if outside the community, so what error should I throw?)
  4. Whats the purpose of the 'price' attribute in the Amenity domain? Should the user be paying at the time of booking or its a membership fee?

If you could answer these queries would help a lot in the implementation. :) If you add your thinking that would also be good.

Great thoughts BTW.

  1. Let's not do this.
  2. Yes. Booking overlap should be restricted.
  3. HTTP 403 can be returned in case. Note: Implementation has to use AuthorizationFilter rather than having the logic in the controller. master has similar implementations already.
  4. User is not expected to pay for the amenity while booking. The idea is, CommunityAdmin might be able to generate a payment for a particular user for using an amenity.

@douglas-oliveira-talkdesk

@tomsajuk Are you working into this task? If not, can I please get it?
Thanks 👍

@tomsajuk
Copy link
Contributor

tomsajuk commented Oct 24, 2020

@douglas-oliveira-talkdesk sure you can go ahead. Not getting time to work on this.
@jmprathab assign it to him please

@DDmit04
Copy link
Contributor

DDmit04 commented Mar 5, 2021

can I take this?

@mslowiak
Copy link
Collaborator

mslowiak commented Mar 5, 2021

@DDmit04 yes ;)

@jfjara
Copy link

jfjara commented Sep 19, 2021

Hello, Could I take this? Regards

@bayotheman
Copy link

Hi @mslowiak @jmprathab could I take this task?

@bayotheman
Copy link

bayotheman commented Oct 19, 2022

Hi @mslowiak @jmprathab just another reminder, could I take this task?

@alexniko44
Copy link

is this task up for grabs?

@aman-junaid
Copy link

Hi @mslowiak, @jmprathab,

Is anyone working on this?? or its up for Grabs?

@cjhier
Copy link

cjhier commented Apr 1, 2024

Hi @mslowiak, @jmprathab,

Is this up for grabs? I'd like to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Contribute to Hacktoberfest 2020! up-for-grabs up-for-grabs
Projects
None yet
Development

No branches or pull requests