Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full reload + async load can cause model load failure #2

Open
jmquigs opened this issue Mar 21, 2016 · 1 comment
Open

full reload + async load can cause model load failure #2

jmquigs opened this issue Mar 21, 2016 · 1 comment
Labels

Comments

@jmquigs
Copy link
Owner

jmquigs commented Mar 21, 2016

Triggering a full (code + data) reload with F10, then another F10 while that load is in progress, will cause the app domain to get unloaded and the load thread will be terminated. Subsequent reloads will fail because the native code appears to remember that the first load is still in progress.

@jmquigs
Copy link
Owner Author

jmquigs commented Mar 21, 2016

Steps:

  1. Use the launcher to start a game that has some mods
  2. Hit F10 to trigger a full load.
  3. Hit F10 a few more times.

Observed:

  1. mods are never loaded
  2. message about Thread Killed in modelmod log
  3. subsequent attempts to load mod data via F1 or F10 will always fail, though the config & code do appear to be reloaded. Restart required.
    Expected: Hitting F10 while a load is in progress should either gracefully terminate that load or wait for it to complete.

F1 Load binding is not affected because that does not terminate the app domain.

@jmquigs jmquigs added the bug label Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant