Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working list of things to fix #21

Open
4 tasks
jmzobitz opened this issue May 30, 2024 · 1 comment
Open
4 tasks

Working list of things to fix #21

jmzobitz opened this issue May 30, 2024 · 1 comment
Assignees

Comments

@jmzobitz
Copy link
Owner

jmzobitz commented May 30, 2024

Working list of things to fix / adjustments:

  • Check code to see if ungrouping data frames allows for noticeable speed up in performance.
  • If monthly mean is an NA, then the resulting flag should be a 2 (noticed this with WREF, 2022-06 and the env_fingerprint_plot
  • From Ed Ayres:

"In addition to the soil surface flux, I think it would be useful to also output the fluxes between each measurement level and below the deepest measurement level. That would allow users to assess where in the soil profile CO2 is being produced and how that changes (e.g., seasonally, with climate, and with disturbance), which is one of the advantages of the gradient method relative to chamber-based measurements. In addition, I’m not sure if you kept all the original assumptions I made in the code I sent many years ago, but one thing I did was exclude any large negative fluxes as I assumed that indicated a problem with the CO2 concentration profile (normally increasing concentrations with depth leading to positive effluxes), however, I do think there might be transient periods where CO2 concentrations might be higher near the surface than deeper in the profile (causing negative fluxes), so I think it might be best to keep all of the data."

  • Have the number of days to include in the monthly mean an input?
@jmzobitz jmzobitz self-assigned this May 30, 2024
@naupaka
Copy link
Collaborator

naupaka commented Nov 15, 2024

Consider storing the gradient when fluxes are computed to speed things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants