Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colons marked as errors in Javascript case statements #497

Closed
julioolvr opened this issue Jun 19, 2016 · 2 comments
Closed

Colons marked as errors in Javascript case statements #497

julioolvr opened this issue Jun 19, 2016 · 2 comments

Comments

@julioolvr
Copy link

image

Link: http://rouge.jneen.net/pastes/wZ91

I tried this on http://rouge.jneen.net/ which I assume uses the latest version of rouge. I've seen this happen on my blog with middleman-syntax but I can't tell exactly which version of rouge that runs.

I feel bad about reporting this one without a patch since a quick search through the issues in the repo brings up that colons in Javascript are a world of pain. I'll see if I can take a look at it soon and come up with a fix.

@jneen jneen closed this as completed in 890317d Jun 20, 2016
@jneen
Copy link
Member

jneen commented Jun 20, 2016

@julioolvr i think i fixed it - can you confirm this patch does the trick? i... just added a good ol catch-all at the bottom of :root for colons i'm afraid.

@julioolvr
Copy link
Author

That seems to do the trick :) I gave a quick try at implementing the rules for the switch statement according to the spec but it was far from trivial (and that's without even considering that I have to learn the DSL). It seems like a fun weekend project though, trying to implement a small part of the grammar following the spec. Hopefully one of these days I'll send a PR with something.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants