New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Make Tooltip Default Tab Name when Added to List #49
Comments
The logic is a little different, You set the tooltip and have the option to either show the tab name or not, so not sure what the question is? Although, it does look like in OctoPrint 1.5.0 it's not working as expected and the Name is showing no matter what, which I'll be looking into.
I do not plan on this, they should both work without interfering with each other. Also, DargonOrder can be disabled after you modify your sidebar/navbar the way you like and the ordering will remain as that's part of the core OctoPrint functionality and that plugin just provides a UI method of doing the ordering.
You press that button to edit your settings for each individual tab.
That's part of core OctoPrint and there's nothing I can do to get around the collapsing of tabs into the drop-down. If you don't have any names and just have icons you'll notice that you'll see more tabs before they get collapsed. |
1- I understood the option "Use Tooltip as Tab Name" but I was talking about using the name of the tab as a tooltip so that I don't have to add a value in the "Tooltips" field for each tab. 2- Ok and thanks for the information. 3- This is exactly what is annoying. I would have preferred to keep the fact of having an overview of the individual options of each tab. 4- Ok no problem and I just saw that Themeify had the same behavior. |
|
I've defaulted the tooltip text based on the tab's existing name when you add them now in the above commit. If you want to test it out you can install by copying/pasting the URL below into plugin manager > get more > ...from URL and clicking Install.
|
Ok it works but I had to completely reconfigure the plugin because we don't have the default value of the tab for "icon_tooltip" when configuring with the old version 0.5.12. But there's something that doesn't seem natural to me... I would have seen something like that: So you keep the possibility to change the name of the tab AND the tooltip. Also, I think that the tooltip should be enabled by default with the default value of the tab (Plugin). |
I appreciate your feedback on how you think it should be and will take it into consideration. The whole point of the tooltip really was to allow people to still see some form of text when they hover over icons and are not displaying the tab name as a way of identification. I just personally can't see why you would want to have the two have different information in them and just feels like over-complication. |
The tooltip is just an information input that allows the user to know the reason/function/use of the button/icon/text. In my opinion, tooltip customization is of little interest, a user leaving his mouse on an icon just to have the "pleasure" of seeing his customization are very rare :-D I left it in my sample template because you seemed to need it. Also, my initial request was precisely to give the tooltip this function (to recall the original name of the tab). Note: Im a designer UI/UX |
Hello @jneilliii, Thank you very much for all of your hard work on the various plugins you maintain. It is greatly appreciated. On the topic of this comment:
I seem to be hitting this very same problem. Would you prefer that I open a new and separate issue for this? Thank you again! |
Yes, please do @gchedzhemov I had totally forgot about that part of this. |
Hello Jim :)
Another very interesting plugin! However, I will have some questions :
1- Are you thinking of adding the "Use Tab Name as Tooltip" feature?
2- I also use your plugin "OctoPrint-DragonOrder". Do you plan to add "navbar/sidebar" functionalities ? Just to avoid making them duplicate ?
3- With the 0.5.12, I don't have the same configuration layout. Is it normal ?
The problem is that it doesn't make the configuration simple because you don't see all the configurations I applied on each tab.
4- When the number of tabs exceeds the layout and the tabs don't have a name, the drop-drop css always uses the .dropdown-menu { min-width: 160px; } which causes this :
Thank !
The text was updated successfully, but these errors were encountered: