Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show Tab Name" toggle no longer works as expected in OctoPrint 1.5.0 #50

Open
gchedzhemov opened this issue Jan 10, 2021 · 5 comments
Open
Labels
bug Something isn't working solved workaround documented or fix applied

Comments

@gchedzhemov
Copy link

gchedzhemov commented Jan 10, 2021

As mentioned in Issue 49, the "Show Tab Name" toggle no longer works as expected in OctoPrint 1.5.0:

Although, it does look like in OctoPrint 1.5.0 it's not working as expected and the Name is showing no matter what, which I'll be looking into.

Regardless of whether the "Show Tab Name" option is checked or unchecked, the Tab Name is always shown.

  • OctoPrint version: 1.5.2
  • Tab Order version: 0.5.13rc1

Please let me know if any logs, screenshots, or additional information is required.

image

image

@jneilliii jneilliii added the bug Something isn't working label Jan 10, 2021
@jneilliii
Copy link
Owner

Thanks for splitting this out.

@jneilliii
Copy link
Owner

jneilliii commented Sep 16, 2021

@gchedzhemov is this still an issue, I can't seem to reproduce it and am wondering if there is a plugin conflict?

Edit: Correction, I am able to reproduce.

@jneilliii
Copy link
Owner

I think I have this issue resolved with the above commit and available as version 1.0.0rc2. You can change the release channel for the plugin to Release Candidate in OctoPrint's software update settings.

@jneilliii jneilliii added the solved workaround documented or fix applied label Sep 16, 2021
@gchedzhemov
Copy link
Author

Thank you! Can confirm resolved with 1.0.0rc2!

image

@jneilliii
Copy link
Owner

Great news. I may still end up tweaking the settings a little prior to release, based on some of the discussion in #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working solved workaround documented or fix applied
Projects
None yet
Development

No branches or pull requests

2 participants