Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme do not apply correct if selected dark mode in Gnome 42 #180

Closed
phush0 opened this issue Apr 7, 2022 · 8 comments
Closed

Theme do not apply correct if selected dark mode in Gnome 42 #180

phush0 opened this issue Apr 7, 2022 · 8 comments

Comments

@phush0
Copy link

phush0 commented Apr 7, 2022

Before submitting

  • Ensure that the issue is present with the latest Arc-theme release, or latest git snapshot.
  • Test whether the issue also appears with default themes (e.g. Adwaita for GTK and GNOME).
  • Make sure you have built the correct theme versions for GTK 3, GNOME Shell and Cinnamon themes.
  • Make sure the issue persists between restarts.
  • For GTK 3 related issues, try clearing your user's ~/.config/gtk-3.0/gtk.css, if it exists.

Details

Screenshot from 2022-04-07 10-30-34

Please add the following information:
Screenshot from 2022-04-07 10-30-48

  • Distribution and version. - Arch 5.17.1
  • Versions for the affected applications/desktops/toolkits. Gnome 42
  • Installation method (package or compiled manually). AUR
  • Arc-theme version. master

Unless this is a non-visual issue, always add screenshots to help describe your problem.

@jnsh
Copy link
Owner

jnsh commented Apr 7, 2022

This seems to happen with Arc-Dark variant, where there is no separate dark theme available. Apparently with the new dark style preference, Adwaita-Dark is used instead of falling back to using the "regular" Arc-Dark, which was the old behavior when applications requested dark theme.

Fix will be pushed shortly.

@jnsh jnsh closed this as completed in 73ada85 Apr 7, 2022
@FreddieChopin
Copy link

BTW why some applications - like the control panel in the background on the screenshot - don't use Arc theme now? Is this something that is missing in Arc (gtk4?) or maybe there was some change in GNOME and some windows are not-theme-able now? This also happens for "Extensions" application, calculator, but works fine for a lot of others (like gedit, gnome tweaks, ...).

@jnsh
Copy link
Owner

jnsh commented Apr 12, 2022

@FreddieChopin See e.g. this post: https://bbs.archlinux.org/viewtopic.php?pid=2030402#p2030402

@jhanschoo
Copy link

Hi, is it possible to release a new build incorporating this fix?

@jnsh
Copy link
Owner

jnsh commented Jul 20, 2022

@jhanschoo I should have some time to get back at Arc-theme again next week, and I'll look at fixing some pending things, and then will likely roll out a new release.

@jhanschoo
Copy link

jhanschoo commented Oct 11, 2022 via email

@evenfrost
Copy link

@jnsh I'm not familiar with the package release procedure for Ubuntu, but is it possible to release 20221218-1 for the current Ubuntu distribution (22.10)?

I see that this release exists only for 23.04, which is not released yet.

@jnsh
Copy link
Owner

jnsh commented Jan 18, 2023

@evenfrost I'm not responsible for distribution packages. I don't think ubuntu backports packages for the theme, but you could try opening a bug report for them.

I think newer .deb packages from other ubuntu versions or debian based distributions could work though, except for gnome-shell and cinnamon themes could have issues if the versions aren't matching with the ones shipped on your distribution.

If nothing else works, you can always build the theme yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants