Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-shell Arc-Dark button/icon/text color #37

Closed
mbacou opened this issue Apr 25, 2020 · 5 comments
Closed

gnome-shell Arc-Dark button/icon/text color #37

mbacou opened this issue Apr 25, 2020 · 5 comments

Comments

@mbacou
Copy link

mbacou commented Apr 25, 2020

Just installed arc-theme_20190917+git20200328-2_all.deb on Ubuntu 19.10, Gnome 3.34.2.

Everything is OK on Gnome Shell Arc an Arc Light variants, but on the Arc Dark variant, there are a few button/icon/text color problems:

Arc
image
Arc-Dark
image

image

Thank you for maintaining this fantastic theme!

@mbacou mbacou changed the title Arc-Dark Arc-Dark button/icon/text color Apr 25, 2020
@mbacou mbacou changed the title Arc-Dark button/icon/text color gnome-shell Arc-Dark button/icon/text color Apr 25, 2020
@jnsh
Copy link
Owner

jnsh commented Apr 25, 2020

Thank you for the report.

I'm fairly sure the issue here is that the GNOME Shell theme is built for wrong version. The shell theme usually requires major changes for between GNOME releases, and for that reason the correct gnome-shell version has to be determined at build time.

I'm quite sure the arc-theme_20190917+git20200328-2_all.deb Debian package is built for GNOME 3.36, so it shouldn't look correct when used with GNOME 3.34.

Either try updating to GNOME 3.36, or build the theme yourself with --with-gnome-shell=3.34 build option.

@mbacou
Copy link
Author

mbacou commented Apr 25, 2020

OK thanks, will try that!

@mbacou
Copy link
Author

mbacou commented Apr 26, 2020

Here is a report with arc-theme_20190917+git20200328-2_all.deb on Ubuntu 20-04, Gnome 3.36.1.

Only noticeable problem is wth the OpenWeather extension. I assume it's missing some more contrasting icon/text colors?

Thx!

Arc-Dark
image

@jnsh
Copy link
Owner

jnsh commented Apr 26, 2020

Thanks, I can reproduce the problem with the OpenWeather extension also. However, the same problem seems to be present when using the default gnome-shell theme as well, and has been reported for the extension here.

I'd imagine the icon/text colors could be fixed from the theme as well, until the extension is updated. Looks like the mouse-over effect for the OpenWeather extension buttons could also be improved/should have a border. I'll investigate these once I got some more urgent things sorted out.

@jnsh
Copy link
Owner

jnsh commented Jun 1, 2020

The OpenWeather extension text color is finally fixed with 2f38b0d:
Screenshot from 2020-06-01 09-35-12
There's some chance that future changes to the extension might break the styling again. Please let me know if that ever happens, or if you encounter any other issues. Also, the mouseover effect for the bottom button is still a bit off, but I couldn't figure out a workaround for them unfortunately.

Thanks again for the report.

@jnsh jnsh closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants