For GTK2, building just the dark variant fails if the expected light variant assets are not also built. #122
Conversation
|
Thank you. Nicely spotted and the fix should be correct. Could you just improve the commit message a bit, by adding a separate subject line at the beginning, e.g. |
|
Hey jnsh, thanks for the hint; my first ever PR. An amended commit message has been pushed - hopefully in an appropriate manner. |
|
Looks like I made a mistake on my suggestion for the first message line. That should have been Otherwise this looks perfect. Thank you! Generally it's recommended to always have the first line as a separate title/short summary, as that works best for many |
For GTK2, building just the dark variant fails if the 'light_menubar_toolbar_assets' are not rendered. #122
|
Cheers for the advice and reference on best practice! |
|
Merged. Thanks again! |
For GTK2, building just the dark variant fails if the 'light_menubar_toolbar_assets' are not rendered. jnsh#122
For GTK2, building just the dark variant fails if the 'light_menubar_toolbar_assets' are not rendered. jnsh#122
For GTK2, building just the dark variant fails if the 'light_menubar_toolbar_assets' are not rendered. jnsh#122
For GTK2, building just the dark variant fails if the expected light variant assets are not also built. Reason: the dark and darker variants use both 'light_menubar_toolbar_assets' and 'dark_menubar_toolbar_assets'. Fix: always build the light assets.