Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-user volume slider not working #11

Closed
mozzieongit opened this issue Jan 28, 2022 · 3 comments
Closed

per-user volume slider not working #11

mozzieongit opened this issue Jan 28, 2022 · 3 comments
Labels
invalid This doesn't seem right

Comments

@mozzieongit
Copy link

Describe the bug
The per-user volume slider doesn't change the user volume.

To Reproduce
Steps to reproduce the behavior:

  1. Install plugin (version 1.3.5)
  2. Open BBB room
  3. Try to change the volume of a user
  4. See slider visually change (and stay that way)
  5. Hear no difference in volume

Expected behavior
The volume of the specified user should change.

Screenshots Logs
The browser console is full of warnings created by volume.js line 171

Real value:0.8
Global:0.8
Per User (<redacted>):1

console.log(speakerName); and console.info(document.getElementsByClassName("userNameMain--2fo2zM")[0].children[0].innerText.trim()) show different names (if that is of value). The speakerName is the correct name of the person talking and the userNameMain...innerText... is my own name.

Software information

  • Plattform: Linux (5.10.93-1-MANJARO x86_64)
  • Firefox version: 96.0.2 (64-bit)
  • BigBlueButton client version: 2478
  • Add-On version: 1.3.5
  • User-Type: normal user
@Theoosaa
Copy link

Ich habe das Problem auch.
Bin aber auf Windows, ansonsten ist alles gleich bei mir.

@Jo0001
Copy link
Owner

Jo0001 commented Jan 28, 2022

First of all thanks for your detailed report!

Short answer: everything is working as expected

Long answer:
The first console.log() is the output of the detect speaker, the console.info(userNameMain...innerText... ) outputs the logged in BBB users. Then there is a check so that the custom volume is only triggered if its another users (and not you self) speaking. The console.warn() is just another debug, not an actual warning. I'm gonna release a version where all that debug stuff is just .log() and not .warn() to make things clear.
Now to the 'not working' / 'working as expected' part:
Its only possible to apply the the volume change when there is a change to detect (new user speaking, speak break ,...) so while the user is talking (A) you wont see an instant effect but as soon as he makes a break (to catch some air xD) (B) or another user talks the new volume is applied.
grafik

I gonna add some info about this to the description/readme.✓

In case you have further question, feel free to reply

@Jo0001 Jo0001 added the invalid This doesn't seem right label Jan 28, 2022
@mozzieongit
Copy link
Author

Understood. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants