Do not apply exactness to types containing indexers #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I have found an edge case affecting those using older versions of Flow (<0.126.0), which this PR aims to solve.
It's easiest to see what this PR does with some examples:
The
...
here is ignored by Flow, so it can be removed--no-inexact
Using indexers in exact objects was unsupported in Flow up until v0.126.0.
Same as above; no exact syntax for types containing indexers.
An "exact" object with an indexer doesn't really make sense, since the purpose of the indexer is to allow you to provide arbitrary keys, so removing exactness from an object with an indexer should be a no-op in Flow >=0.126.0 and should fix unusable types for older Flow versions
Thank you so much to all the contributors! ❤️
flowgen
is a fantastic tool!