Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #13

Closed
demijohn opened this issue Apr 29, 2014 · 2 comments
Closed

Windows support #13

demijohn opened this issue Apr 29, 2014 · 2 comments

Comments

@demijohn
Copy link

Hi,

you declared there is theoretical Windows support (and I see $this->runWindows($job, $config); in your code) , but you use "posix" php extension:

if (! extension_loaded('posix')) {
throw new Exception("'posix' extension is required");
}

and this extension is not available for Windows.

@hellogerard
Copy link
Member

I think at one time, it worked on Windows, but then posix commands got pulled in which made in the README inaccurate.

I'm afraid I wouldn't be the one to work on this. @demijohn, if you can get it working on Windows, I'd happily merge a PR :-)

I'd take out that extension_loaded check (or maybe only checkon *nix), and search the code for anywhere a posix_ function is used, and ensure the platform is *nix.

@hellogerard
Copy link
Member

Finally got a chance to look at this @demijohn. I think at least you won't get posix_ errors on Windows now. Can you test version v2.0.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants