Upstream master #16
Closed
Upstream master #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: [http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest](http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest) These params are allowed to be used during Authentication request.
* Add logout phase * Avoid to make a discover for each other_phase call * avoid using match when MatchData is not used
* fix: Allow rails applications to handle state mismatch * Addressed reviewer-bot
* Allow state method to receive env I have a state algorithm that requires access to values in env. This change allows it to receive that reference in a backwards compatible way and brings the state method in line with the setup method. * Add parenthesis and eliminate ternary operator * Add test for dynamic state generation
* Set default OmniAuth name to openid_connect If no name option is given, OmniAuth will attempt to translate OmniAuth::Strategies::OpenIDConnect to openidconnect. This led to confusion for a number of GitLab users who omitted the name argument because /users/auth/openid_connect did not match /users/auth/openidconnect. * Fix tests to use openid_connect
It's used by things like Dependabot to find commit diffs, changelogs, etc., and currently points to the wrong place.
* Add support for response_type id_token * Simplify the response_type validation * Remove unnecessary statements from README
…uth#35) Apparently it never worked as a symbol, although it was mentioned in README
…niauth#36) * Cast response_type to string when checking if it is set in params Rails will provide params with indifferent access but that's not guaranteed with other frameworks. Omniauth sets keys as string, e.g. hash[field] = request.params[field.to_s] * Define a normalized response_type method for use in string comparisons
* The complete id_token is now a part of the hash that is returned to the application * Bugfix: Redefining env method for Strategy class caused race condition in test execution
Some OIDC providers allow extra paramters, not convered by the default configuration we pass through. An example of this is Azure AD, which adds the `resource` parameter which is used to scope access of the resultant access token. This adds the ability to pass through custom attributes, as a catch all, to the authorize URI.
* Provide more information on error * Better information on invalid state * Change working with callback error
* added table for options information * added table for client options configuration
…rty (omniauth#52) Co-authored-by: Luca Leonardo Scorcia <lucaleonardo.scorcia@mise.gov.it>
…ResponseObject::IdToken:0x0000000008d9dde0>): (omniauth#60) since id_token gets decoded twice fix omniauth#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a branch dedicated to follow the main branch of https://github.com/m0n9oose/omniauth_openid_connect.
It also includes a feature to add params to the authorize request omniauth#90
This PR has to be used as it.