Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: NoMethodError (undefined method `count' for #<OpenIDConnect::ResponseObject::IdToken>): #60

Merged
merged 1 commit into from
May 25, 2020

Conversation

ignatiusreza
Copy link
Contributor

since id_token gets decoded twice

fix #59

…ResponseObject::IdToken:0x0000000008d9dde0>):

since id_token gets decoded twice
@ignatiusreza
Copy link
Contributor Author

not sure what is wrong with the rubocop linter action.. doesn't looks like it's related to the changes.. 🤔

@m0n9oose m0n9oose merged commit 6398ad1 into omniauth:master May 25, 2020
@ignatiusreza ignatiusreza deleted the bugfix/id_token branch May 26, 2020 05:29
ahukkanen added a commit to mainio/omniauth-tunnistamo that referenced this pull request Jun 11, 2020
There was a bug in the previous release that caused the id token
based authentication to fail:
omniauth/omniauth_openid_connect#60
papayaah added a commit to health2works/omniauth_openid_connect that referenced this pull request Oct 7, 2022
…0.4.0

* upstream/master: (32 commits)
  Fix date in CHANGELOG.md
  Fixes rubocop issues
  Setup Coveralls.io as Github Action
  Fix rubocop errors
  Replace deprecated rubocop_linter_action
  Update README.md
  Fix date on CHANGELOG.md
  Update VERSION to v0.4.0
  Update CHANGELOG.md for v0.4.0
  Support dynamic parameters to the authorize URI (omniauth#90)
  Upgrade Faker and replace Travis with Github Actions (omniauth#102)
  Try to fix rubocop documentation_url not round error.
  Make `omniauth_openid_connect` gem compatible with `omniauth v2.0` (omniauth#95)
  Fall back to the discovered jwks when no key specified (omniauth#97)
  Allow to update omniauth to 2 (omniauth#88)
  Update README.md
  Bump version to 0.3.5
  bugfix: info from decoded id_token is not exposed (omniauth#61)
  bugfix: NoMethodError (undefined method `count' for #<OpenIDConnect::ResponseObject::IdToken:0x0000000008d9dde0>): (omniauth#60)
  Bump version to 0.3.4
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `count' for nil:NilClass
2 participants