Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin makes HomeBridge unresponsive if fan is not connected #88

Closed
lin-toto opened this issue Jun 13, 2019 · 11 comments · Fixed by #94
Closed

Plugin makes HomeBridge unresponsive if fan is not connected #88

lin-toto opened this issue Jun 13, 2019 · 11 comments · Fixed by #94

Comments

@lin-toto
Copy link
Contributor

If this plugin can’t connect with the Dyson fan, it makes the whole HomeBridge unresponsive. Not only the fan but also other HomeBridge-controlled devices in HomeBridge won’t respond to the Home app.

@Hucksleyy91
Copy link

I have that issue with some accessories and there is a simple fix create another homebridge instance and just put that accessory in there I use a app currently in beta atm called Homemanager on iOS

@alexlijw
Copy link

alexlijw commented Jun 15, 2019

Hey guys, I used to experience the same issue. But I just tried to put dyson at the first place in the platform, then it works! I have a HP02 pure cool hot link, by the way.

"platforms": [ { "platform": "DysonPlatform", "name": "DysonPlatform", "email": "xx@gmail.com", "password": "xxxxx", "accessories": [ { "ip": "192.168.2.56", "displayName": "dyson", "serialNumber": "DYSON-PT4-EU-xxx-455", "password": "xx", "autoModeVisible": false, "nightModeVisible": false, "focusModeVisible": true } ] }, //then come other equipment. { "platform": "Hue", "users": {

@jasper-seinhorst
Copy link

I've had this issue multiple times. Your dysons ip adres probably changed or was not responding for a while. Turn of your dyson 10 seconds (unplug from wall) and restart your homebridge instance should "fix" your problem.

If that doesn't work try to restart your router when you turn off your dyson.

@PrzemyslawKlys
Copy link

@jasper-seinhorst it's not about IP changing. It's about disconnecting Dyson from Power. My girlfriend sometimes disconnects Dyson to connect other device and while it's disconnected whole home bridge hangs so any other device is uncontrollable. It would be cool to have a fix for this.

@skcuslleb
Copy link

Unfortunately, this part of Homebridge's current architecture. If one plugin is unresponsive the entire instance of Homebridge is unresponsive. The solution is to start a separate Homebridge instance for each plugin/device. I have 7 instances running, and if any device is unresponsive everything else continues to function.

It's no use registering issues with the individual plugins. This is something that has to change in Homebridge itself. I believe it's on their roadmap, or at least was talked about a while back.

@ericcastro
Copy link

@afrustagli not true. I have other homebridge devices that I can disconnect entirely and won't affect the others (example homebridge-mqtt)

@ifeign
Copy link

ifeign commented Jul 29, 2019

This is a major flaw with this plugin, @afrustagli is incorrect, as every other plugin I use is able to fail gracefully. @joe-ng please take a look at this, it is probably the most urgent issue with this plugin

@robertgranholm
Copy link

+1 for this issue, if the fan isn't on...all of homebridge goes unresponsive...bummer!

Any feedback on @afrustagli if/when this will be fixed? Thank you!

@robertgranholm
Copy link

Any feedback or way to fix this?

@lin-toto
Copy link
Contributor Author

Guys so I eventually did some debugging myself and the problem is pretty simple, the plugin is missing a check for fan connected in isNightMode.

I patched that and it now seems to work just fine. #94

@ericcastro
Copy link

Thank you so much for taking a look. I will try this ASAP and come back with a confirmation that it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants