Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Add Google App Engine Compatibility #58

Closed
derekperkins opened this issue Aug 15, 2014 · 3 comments
Closed

Add Google App Engine Compatibility #58

derekperkins opened this issue Aug 15, 2014 · 3 comments

Comments

@derekperkins
Copy link
Contributor

I'm using the Google App Engine local dev environment and they use a goapp binary instead of the normal go binary, which includes their "appengine" packages to be referenced as if they were part of the standard library. If the "Go Installation" variable allowed for setting a binary as well as the path, that should make things work peachy. :)

https://developers.google.com/appengine/docs/go/tools/devserver#Go_Using_the_goapp_tool

@joefitzgerald
Copy link
Owner

The Go Installation preference is indeed an absolute path, but I look for it to end in go (https://github.com/joefitzgerald/go-plus/blob/master/lib/goexecutable.coffee#L41). Would be a simple fix to get past that.

@derekperkins
Copy link
Contributor Author

I've never used coffeescript before, but would it be as simple as adding an or when looking for the executable name?

and goinstallation.lastIndexOf(path.sep + 'go') is goinstallation.length - 3 or and goinstallation.lastIndexOf(path.sep + 'goapp.bat') is goinstallation.length - 10

@derekperkins
Copy link
Contributor Author

Sorry about my coffeescript issues with the PR. I can confirm that simply replacing the old Windows executable code with goinstallation.lastIndexOf(path.sep + 'goapp.bat') is goinstallation.length - 10 does work as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants