Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing of data to popover #225

Open
Lolmewn opened this issue Aug 3, 2020 · 2 comments
Open

Allow passing of data to popover #225

Lolmewn opened this issue Aug 3, 2020 · 2 comments

Comments

@Lolmewn
Copy link

Lolmewn commented Aug 3, 2020

Bug, feature request, or proposal:

In Angular Material, it is often possible to pass data (sometimes referred to as context) to elements (see e.g. https://material.angular.io/components/dialog/overview#sharing-data-with-the-dialog-component). It would be great if this was possible for this Popover module, too.

What is the use-case or motivation for changing an existing behaviour?

The main benefit of this is that you can re-use a Component or TemplateRef with dynamic data.

Which versions of Angular, Material-Extended, OS, TypeScript, browsers are affected?

Using Angular 10.0.4 with Material-Extended 3.0.3

@joejordanbrown
Copy link
Owner

@Lolmewn

This is something I plan to do in the next version that I'm working on. But, the only issue is that the popover API will change a lot and rely on a service etc just like the dialog. It might mean that I have to keep both popover variations updated for a while until everyone has switched over to a newer cleaner API.

It's still a work in progress though and probably won't be finished for many months.

@netronx
Copy link

netronx commented Mar 29, 2021

Use ComponentPortal instead of TemplatePortal, you have to do a little work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants