useClick problem in IE9 and Firefox

[agentfitz]

I am noticing that the new useClick option has an issue in IE9 and Firefox. On the very first click, the dropdown menu is show and hidden immediately. On subsequent clicks, it behaves as expected. This can be seen on the Superfish examples page under the "require click" tab.

[joeldbirch]

It looks like this is probably due to my less-than-ideal tabbed examples. The submenus are setup while hidden inside tabs, which they don't like. I'll get around to updating the docs eventually. I'm really snowed under with other more pressing bugs, now. Thanks for the report.

[dariodev]

Version 1.5.11 was OK, the issue occurs in later versions, 1.5.12 and 1.5.13. As agentfitz said, the issue occurs in Firefox and IE9 (don't know for other IE versions), while in Opera, Safari and Chrome everything works right.

Problem could be in the line 123. Menu works fine when I change this line as follows:

$liHasUl.not('.'+c.bcClass).children('ul').show().hide(); // -
$liHasUl.not('.'+c.bcClass).hideSuperfishUl(); // +

Please check at jsFiddle http://jsfiddle.net/dariodev/wwPdY/15/

[agentfitz]

Checked in the fiddle and also in my own implementation and the patch works perfectly as described in both places. Awesome stuff!

[joeldbirch]

That line changed to .show().hide() in order to support submenus hidden with display:none in the CSS. We'll have to work out something else in the long-term. Also, just a warning: don't get too attached to the useClick behavior. I've never received the feedback I need re use cases, and I'm wanting to make it work more like how touch interaction works (first click opens, second follows link). Consider it an experimental feature (I'll update the docs).

[agentfitz]

Thanks for the response, Joel. Personally, I think it's a great feature to have in Superfish as my team gets requests all the time for expand/collapse style menus such as this one: http://liverpoolhtml5.photobiz.com/ (click the information or galleries link to see effect)

[joeldbirch]

That's a fair use case, thanks for that.

[joeldbirch]

This is all fixed in v1.6.0!

[agentfitz]

Nice!

No matter how many times these knucklehead back-end developers ask me "what the heck is a superfish?" I'll still tell'em... the best js menu plugin on the web! Thanks Joel!

[joeldbirch]

Aw, thank you sir! Always nice to have one's efforts appreciated :D

[dariodev]

True indeed, the best one!

Thanks Joel, and thanks for insanely fast development in last two months :)