Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paired eras #17

Open
joeroe opened this issue Nov 11, 2020 · 1 comment
Open

Paired eras #17

joeroe opened this issue Nov 11, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@joeroe
Copy link
Owner

joeroe commented Nov 11, 2020

CE-based eras come in pairs, i.e. negative values of CE are BCE; negative values of BCE are CE. There is currently no concept of this in era. I can think of two ways to add it:

  1. As part of the definition of an era, e.g. add an inverse attribute that contains another era.
  2. As a function, which takes a year vector with negative values and splits it into two positive vectors with paired eras.

The underlying question is whether it makes sense to support paired eras in analytical use (in which case we'd need 1) or just for printing and plotting (then 2 would be enough).

@joeroe joeroe added the enhancement New feature or request label Nov 11, 2020
@joeroe joeroe added this to the v1.0 milestone Nov 11, 2020
@joeroe
Copy link
Owner Author

joeroe commented Mar 9, 2022

Along with this, could add something like yr_earlier() and yr_later() to add and subtract years respecting their direction and paired era.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant