Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review frus1917-72PubDip #17

Closed
8 of 12 tasks
seckroth opened this issue Jul 29, 2014 · 5 comments
Closed
8 of 12 tasks

Review frus1917-72PubDip #17

seckroth opened this issue Jul 29, 2014 · 5 comments

Comments

@seckroth
Copy link
Collaborator

  • Passes FRUS TEI Schematron check
  • Passes RelaxNG schema check
  • Commit schema-compliant file to SVN
  • Upload the FRUS TEI file into localhost
  • Upload page images to S3
  • Typography and characters
  • Source note coding
  • Table of contents
  • Front matter
  • Back matter
  • Random sample
  • Volume metadata
@seckroth
Copy link
Collaborator Author

For DSCS:

  • missing source note coding
  • missing abbreviation and person-list ref/@target and persName/@corresp tags in documents
  • missing <pb/> tags
  • cross-references not tagged

@seckroth
Copy link
Collaborator Author

d#6, 13, 27, 33, 35, 36, 37, 41

  • signature incorrectly formatted. (<affiliation> is inside the <signed> portion of closer) and no <lb/> in signature

waiting on Preface to fully review front matter

@joewiz
Copy link
Owner

joewiz commented Nov 12, 2014

I uploaded the latest to SVN and fixed schema issues in this version:

  • Wrong volume ID in the <idno> header element
  • Each section of the appendix needs its own <div type="section" xml:id="appendix-1"> (and 2 and so on); schema complained of head elements missing div elements

I also fixed this issue that DSCS should have caught:

  • Need to remove .tif file extension from graphics, since web vs. print outputs use different image formats

I added the embedded video code to Appendix 5 and 11, and uploaded some sample images to S3 so the "still clip" that shows above the videos would display.

DSCS still needs to address these issues:

  • Need to supply @type="source", still missing on all source notes
  • Need to properly code left & right alignment on the same line as documented at Develop guidelines for aligning document identifiers with dateline #12 (and as instructed in June email re: #d13)
  • Need to convert character entities (search for &# for all 4 instances) to actual Unicode characters
  • Need to tag cross references to documents in Appendix source notes

@joewiz
Copy link
Owner

joewiz commented Nov 13, 2014

  • Also, need to tag cross references to Appendices in the body documents

@joewiz
Copy link
Owner

joewiz commented Aug 18, 2016

This issue was moved to HistoryAtState/frus#16

@joewiz joewiz closed this as completed Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants