Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering offline does not work #140

Closed
brian-bk opened this issue Sep 15, 2015 · 1 comment
Closed

Rendering offline does not work #140

brian-bk opened this issue Sep 15, 2015 · 1 comment

Comments

@brian-bk
Copy link

Hello, I really like the project and I use it to render my notes to markdown. But sometimes I work offline, and grip does not work. I see there is a render_offline that is set as default to False, but nowhere else is it set.

By hardcoding in render_offline = True in renderers.py, I see it works, and it uses the cached github renderer.

Can you add either a ping test to the script to set render_offline or at the least an argument into the parser like --render-offline? Thanks.

@joeyespo
Copy link
Owner

Thank you!

There's currently a half-working implementation that isn't exposed to the CLI (as you've discovered). #35 is the long-standing issue on this.

It'll eventually be production-ready, but is lower on the list at the moment. (I wouldn't be opposed to a PR that exposed an --offline CLI argument, but didn't document it in the usage though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants