-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modifications to class_interface.c #19
Comments
I haven't used Cython at all myself, so don't really know how to do your bullet point (1), but I'd be happy to accept contributions :-) I can certainly do (2), that's straightforward. Then I can have a play with (3), after (1) is in place. |
Great, thanks for point 2. As of point 1, I can send you the modified version of classy.pyxd classy.pyx. How's best to send them? |
@amoradinejad if you know how to do a pull request then that's the best way to make sure your contribution is recorded. There's a "fork" button at the top right of the page, if you click that you'll get your own version on github. Then you can push your changes to that changed repository and then make a pull request from the tab with that name. That's what I'd recommend, since it offer an easy way of reviewing the changes, as well as preserving your authorship of them. But you can also just email me the new versions of the file if you'd prefer not to. |
I've added feature (2) - see the module.yaml file in the class directory for the option names. |
Hi @joezuntz
I noticed that you now replaced the old version of class_v2.7 with the latest version of class_v3.2. That's really great, I had to do it myself, but it's very nice that it is consistently replaced.
I have a few suggestions and a question about some modifications to class interface that may be helpful for some users, as I needed them myself.
boltzmann/class/class_v3.2.0/python/classy.pyxd
add the definition of the new function of perturbations.c module in class_v3.2,perturbations_sources_at_k_and_z()
, which calculates transfer function for a choice of (k,z)boltzmann/class/class_v3.2.0/python/classy.pyx
include a call to the above function, lets say calledtk_lin()
in analogy topk_lin()
,tk_lin()
inboltzmann/class/class_interface.py
.class_interface.py
to have the option of only calculating matter power spectrum and transfer function,'mPk mTk'
as one can do when running class directly.p(k)
and dividing it to primordial power spectrum and then building an interpolator for transfer function usinginit_interp_2d_akima_grid()
, which extends the k-range covered bypk()
extrapolator. But this seems too convoluted. There is perhaps a better way of doing this?The text was updated successfully, but these errors were encountered: