New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File sync not working for android versions below Q #36
Labels
bug
Something isn't working
Comments
Hey @johannesjo, by file upload do you mean filesync? If yes, then that's normal, because scoped storage is only implemented in android 10+ so we open the folder picker dialog only on these, but for lower versions it uses the old permission system. I did not test with Android 9, if it doesn't work, then we can just change the condition to lower:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O)
To:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P)
For Android 9.
I'll try various versions of android to ensure if it all works as expected for older versions, I'll post here my results.
2 févr. 2023 20:46:20 Johannes Millan ***@***.***>:
… Hey hey @lrq3000[https://github.com/lrq3000] ! Could I maybe ask you to have another look at this? I am try to get this to work on my phone which runs on android 9. Unfortunately there is never a permissions dialog opened and without it it doesn't seem to be able to write the file.
—
Reply to this email directly, view it on GitHub[#36], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAIRFXXNOFB3OXAJFC2LBB3WVQFIXANCNFSM6AAAAAAUPOAB3A].
You are receiving this because you were mentioned.[Image de pistage][https://github.com/notifications/beacon/AAIRFXWQ6YBDWAFLLKSYYUTWVQFIXA5CNFSM6AAAAAAUPOAB3CWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHF3ABYSI.gif]
|
johannesjo
changed the title
File upload not working for android versions below Q
File sync not working for android versions below Q
Feb 3, 2023
Yes sorry! File sync of course! I tried changing the if condition, but that didn't do the trick. Would be great if you could have another look at this! |
Ok i see then maybe a regression was introduced somewhere, I'll have a look, thanks for the heads up.
3 févr. 2023 13:34:50 Johannes Millan ***@***.***>:
… Yes sorry! File sync of course! I tried changing the if condition, but that didn't do the trick. Would be great if you could have another look at this!
—
Reply to this email directly, view it on GitHub[#36 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAIRFXQPERVWVDIT24P7G5TWVT3OVANCNFSM6AAAAAAUPOAB3A].
You are receiving this because you were mentioned.[Image de pistage][https://github.com/notifications/beacon/AAIRFXUATLTRUV3LRIVLP6DWVT3OVA5CNFSM6AAAAAAUPOAB3CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSUMOL7O.gif]
|
@johannesjo I get a fatal error on just opening SP on Android 9: johannesjo/super-productivity#2451 Do you get the same? I also tested Android 10, no problem there. |
lrq3000
added a commit
to lrq3000/super-productivity-android
that referenced
this issue
Feb 4, 2023
Signed-off-by: Stephen L. <lrq3000@gmail.com>
10 tasks
johannesjo
added a commit
that referenced
this issue
Feb 6, 2023
Filesync compatibility with Android <= 9 (fixes #36) + critical bugfixes for Android <= 7.1.1 and 13
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey hey @lrq3000 ! Could I maybe ask you to have another look at this? I am try to get this to work on my phone which runs on android 9. Unfortunately there the permissions dialog is never opened and without it it doesn't seem to be able to write the file.
The text was updated successfully, but these errors were encountered: