Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving away from libuv #9

Closed
johnae opened this issue Sep 30, 2015 · 6 comments
Closed

Consider moving away from libuv #9

johnae opened this issue Sep 30, 2015 · 6 comments

Comments

@johnae
Copy link
Owner

johnae commented Sep 30, 2015

Using something built only for fs change notifications would reduce binary size and probably be give more information about "what happened". This could be one option:

https://github.com/emcrisostomo/fswatch

Another option might be to simply use ffi and hook into whatever notification system the fs has.

@johnae
Copy link
Owner Author

johnae commented Sep 30, 2015

Or maybe https://github.com/passcod/rsnotify which is written in rust but with a less restrictive license.

@johnae
Copy link
Owner Author

johnae commented Dec 3, 2015

This might be a fun thing to do but also sort of pointless. The binary isn't very large and we get lots of nice features with libuv.

@johnae johnae closed this as completed Dec 3, 2015
@johnae
Copy link
Owner Author

johnae commented May 1, 2016

One project that may be interesting is cqueues: http://25thandclement.com/%7Ewilliam/projects/cqueues.pdf and https://github.com/wahern/cqueues

As long as Windows support isn't interesting at least. Tbh there's already a dependency on ljsyscall (though only very limited usage) so Windows wouldn't "just work" anyway.

@johnae johnae reopened this May 1, 2016
@johnae
Copy link
Owner Author

johnae commented Sep 11, 2016

This will most probably be done using direct system calls instead as it provides the most control. I already have a somewhat working prototype for Linux and a branch will be up relatively soon.
It also has the nice property of removing dependencies. There will be no libuv or cqueues dependency when this is done, only luajit and some vendored lua code.

@johnae
Copy link
Owner Author

johnae commented Sep 19, 2016

Ongoing work in #19

@johnae
Copy link
Owner Author

johnae commented Oct 26, 2016

Done as of 0.7.0.

@johnae johnae closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant