Replace libuv #19
Merged
Replace libuv #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2016
This means that change_handlers are evaluated in order and the first match is the only one that runs. That way more fine grained matches can be defined before catch-all ones and only the fine grained one would run if matching (it being defined before the catch-all). Setting first_match_only to false would run all matching handlers.
Earlier, when loading the spookfile and a previous instance of spook existed, the EventHandlers weren't properly cleaned out and might keep references around indefinitely. Now, when calling stop on spook (which is done when reloading the Spookfile and creating a new spook instance), the EventHandlers are cleared as part of the stop methods. Also, the EventHandlers table isn't updated for any type of event handler until the handler is actually started.
No idea if it works though. Will test later.
Read is really what it is - it notifies with data when fd is readable.
Catch any errors at top level in main, log them at debug level.
The watchnr helper is now internal since it was only built for watching single files. There is now a new helper called "watch_file" that does this less verbosely (it still uses the internal watchnr).
First args.spookfile, then env spookfile, finally current_dir/Spookfile.
Update the Spookfile with some new logic. It's getting cleaner and might be something to include with spook. Still undecided.
That was an unnecessary addition. Just have "add" accept more than one argument, that way it's both shorter and more straightforward to add several notifiers in one go.
|
This is quite close to done now. Perhaps I'm really just being overly careful. Ofc, depending on whether OS X/BSD support is of the utmost importance this is either done or not. For me at this time, OS X and BSD can wait. The main issue on the BSD:s is how kqueue works wrt filesystem changes - that part is quite different from inotify on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on replacing libuv completely with ljsyscall.